refactor(editor): Migrate components to composition API #11497
Conversation
n8n-assistant
bot
added
n8n team
| function onUpdateClick() { | ||
| if (!props.communityPackage) return; | ||
| openCommunityPackageUpdateConfirmModal(props.communityPackage.packageName); | ||
| } | ||
| </script> | ||
|
|
||
| <template> |
There was a problem hiding this comment.
Let's replace the $locale in the template for i18n
| return parsed; | ||
| } | ||
| const usersStore = useUsersStore(); | ||
| const settingsStore = useSettingsStore(); |
There was a problem hiding this comment.
nitpick: Let's keep the order we have in the document
| }); | ||
| const enabledButton = computed((): boolean => { | ||
| return emailsCount.value >= 1; | ||
| }); |
There was a problem hiding this comment.
nitpick: let's add spaces
| return settingsStore.isEnterpriseFeatureEnabled[EnterpriseEditionFeature.AdvancedPermissions]; | ||
| }); | ||
|
|
||
| function validateEmails(value: string | number | boolean | null | undefined) { |
There was a problem hiding this comment.
nitpit: We have a mix of arrow functions assigned to a variable and normal functions. Can we stick to one? ideally the former
| } | ||
| } | ||
| return parsed; | ||
| } | ||
| </script> | ||
|
|
||
| <template> |
There was a problem hiding this comment.
replace $locale from template with i18n
| const { isPublicApiEnabled, isSwaggerUIEnabled, publicApiPath, publicApiLatestVersion } = | ||
| settingsStore; | ||
|
|
||
| const isTrialing = computed((): boolean => { |
There was a problem hiding this comment.
nitpick: const isTrialing = computed(() => cloudPlanStore.userIsTrialing)
There was a problem hiding this comment.
Same with isLoadingCloudPlans
|
|
||
| const isTrialing = computed((): boolean => { | ||
| return cloudPlanStore.userIsTrialing; | ||
| }); |
There was a problem hiding this comment.
nitpick: spaces between functions and maybe arrow functions instead. Also, keep order suggested in the document
| @@ -185,14 +171,14 @@ export default defineComponent({ | |||
| <div :class="$style.hint"> | |||
| <n8n-text size="small"> | |||
| {{ | |||
| $locale.baseText(`settings.api.view.${swaggerUIEnabled ? 'tryapi' : 'more-details'}`) | |||
| $locale.baseText(`settings.api.view.${isSwaggerUIEnabled ? 'tryapi' : 'more-details'}`) | |||
There was a problem hiding this comment.
remove $locale and use i18n instead
| }, | ||
| }); | ||
| } | ||
| } |
There was a problem hiding this comment.
remove $locale from template and use i18n
| await this.getDestinationDataFromBackend(); | ||
| const eventBus = createEventBus(); | ||
| const disableLicense = ref(false); | ||
| const allDestinations = ref<MessageEventBusDestinationOptions[]>([]); |
There was a problem hiding this comment.
nitpick: keep the order suggested in the document
RicardoE105
changed the title
Summary
Migrate the following components to composition API:
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)